Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 328FD200CBD for ; Thu, 6 Jul 2017 09:04:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 30EA016595C; Thu, 6 Jul 2017 07:04:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7759316595A for ; Thu, 6 Jul 2017 09:04:49 +0200 (CEST) Received: (qmail 74696 invoked by uid 500); 6 Jul 2017 07:04:48 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 74685 invoked by uid 99); 6 Jul 2017 07:04:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 07:04:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 65A0B18583A; Thu, 6 Jul 2017 07:04:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Qrm14_xf5iO4; Thu, 6 Jul 2017 07:04:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 250135FCB0; Thu, 6 Jul 2017 07:04:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81938E01D8; Thu, 6 Jul 2017 07:04:37 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0B922C4043E; Thu, 6 Jul 2017 07:04:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8588913047777192652==" MIME-Version: 1.0 Subject: Review Request 60678: GEODE-3151 Configuration Parameter Based Registration Of internal Region over JMX From: dinesh akhand To: Barry Oglesby Cc: geode , dinesh akhand Date: Thu, 06 Jul 2017 07:04:35 -0000 Message-ID: <20170706070435.36467.77195@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: dinesh akhand X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60678/ X-Sender: dinesh akhand Reply-To: dinesh akhand X-ReviewRequest-Repository: geode archived-at: Thu, 06 Jul 2017 07:04:50 -0000 --===============8588913047777192652== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60678/ ----------------------------------------------------------- Review request for geode and Barry Oglesby. Bugs: GEODE-3151 https://issues.apache.org/jira/browse/GEODE-3151 Repository: geode Description ------- I am Adding the Configuration parameter which will have the internal region name/function name which we want to register in JMX. currently for Internal Region Bean is not getting registered in JMX. I want to make this as configurable. If user provided internal region names in configuration[property file ] then bean should get register in JMX. Current use: we want to register the async queue associated internal region in JMX. future scope: using same parameter we want to register few functions to JMX. output : only defined internal regions in property file are going to be show in JMX. Diffs ----- geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java 63f6505101 geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 795f6a5a4a geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java c2a395de0b geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java fbe894c964 geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 6aa602fc8f geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 2dda38c70b geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 3b3047ff00 geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java baad039bf9 geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 525f988cd3 geode-core/src/test/java/org/apache/geode/distributed/internal/InternalDistributedSystemJUnitTest.java 5a191bbd93 Diff: https://reviews.apache.org/r/60678/diff/1/ Testing ------- Manual testing was done for it. Added test case for it. Thanks, dinesh akhand --===============8588913047777192652==--