geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #671: GEODE-3255: Refactor CreateAlterDestroyRegionComman...
Date Mon, 31 Jul 2017 18:31:52 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/671

    GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3255)
    
    `CreateAlterDestroyRegionCommands` was a large class that contained multiple commands.
Each command was refactored into a separate class, and the methods shared by the commands
were refactored into a new and appropriately named class of their own. Tests related to `CreateAlterDestroyRegionCommands`
were also refactored.
    
    **Testing status: Precheckin completed successfully**
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Single, squashed commit
    
    - [x] `gradlew build` runs cleanly
    
    - [x] Tests updated

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3255

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #671
    
----
commit 8a0e27fd3bf44cb63871b8b3b226800a845e0e4c
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-28T21:23:25Z

    GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message