geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings
Date Mon, 24 Jul 2017 18:48:13 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/651

    GEODE-3230: Cleaning up unused (Cli)Strings

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3230)
    
    `CliStrings.java` contained a lot of Strings that were not used anywhere in the code.
In this PR, each of these seemingly unused Strings were examined to find potential uses of
them in the code. Strings that did seem useful were inserted into the code as needed. Strings
that didn't seem to be useful were deleted. Strings that don't seem to be used, but are used
in the closed side, were preserved and tagged as such.
    
    (Note: An attempt was made to use all Strings that weren't currently being used in parts
of the code that seemed appropriate, but most of these were removed because they broke tests.)
    
    **Testing Status**: **Precheckin running**
    
    ### For all changes:
    - [x] JIRA ticket
    
    - [x] PR rebased
    
    - [x] Initial commit is squashed and single
    
    - [x] `gradlew build` runs cleanly
    
    - [x] Tests updated to verify changes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3230

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #651
    
----
commit 06dcd340a33c83cab7b4700a3c56e8fe780d0964
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-21T21:29:55Z

    GEODE-3230: Cleaning up unused (Cli)Strings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message