geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #650: GEODE-3253: Refactoring ClientCommands and related ...
Date Fri, 21 Jul 2017 18:22:54 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/650

    GEODE-3253: Refactoring ClientCommands and related tests

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3253)
    
    `ClientCommands.java` was a large class that contained multiple commands. In this PR,
each command was refactored into a separate class. `ClientCommandsDUnitTest.java` was also
refactored and split into `DescribeClientCommandDUnitTest.java` and `ListClientCommandDUnitTest.java`.
Methods shared by these two tests were moved into a new class, `ClientCommandsTestUtils.java`.
    
    - [x] JIRA Ticket referenced
    
    - [x] PR rebased against develop
    
    - [x] Initial contribution is a single squashed commit
    
    - [x] `gradlew build` runs cleanly
    
    - [x] Tests updated to verify changes
    
    **Testing status**: **Precheckin currently running**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3253

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/650.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #650
    
----
commit bf623e78ed44621f3efd6e5884f3d97d0cac31ee
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-20T23:54:22Z

    GEODE-3253: Refactoring ClientCommands and related tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message