geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deepakddixit <...@git.apache.org>
Subject [GitHub] geode pull request #648: GEODE-3206 : Corrected order of lucene search resul...
Date Thu, 20 Jul 2017 05:35:47 GMT
GitHub user deepakddixit opened a pull request:

    https://github.com/apache/geode/pull/648

    GEODE-3206 : Corrected order of lucene search results based on score.

    * Lucene results with higher score value are more relevant than lower once.
      Used descending comparator for lucene search result based on score,
      so most relevant results will be listed first.
    
    * Added test case to verify the changed order.
    
    * Modified expected result from test case, as the order of result is
      changed to match relevancy of result searched.
    
    * Optimized imports with new style file.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [X] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/deepakddixit/incubator-geode bugfix/GEODE-3206

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #648
    
----
commit 4e0e921793f535fee9827b6c77ba63194bcc0f66
Author: Deepak Dixit <deepakdixit2011@gmail.com>
Date:   2017-07-18T14:07:36Z

    GEODE-3206 : Corrected order of lucene search results based on score.
    
    * Lucene results with higher score value are more relevant than lower once.
      Using descending comparator for lucene search result based on score,
      so most relevant results will be listed first.
    
    * Added test case to verify the changed order.
    
    * Modified expected result from test case, as the order of result is
      changed to match relevancy of result searched.
    
    * Optimized imports with new style file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message