geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #647: GEODE-3271: Refactor WanCommands
Date Wed, 19 Jul 2017 23:35:01 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/647

    GEODE-3271: Refactor WanCommands

    [See the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3271)
    
    `WanCommands.java` was a large class that contained multiple commands. Each command has
been refactored into a separate class, and the methods shared by these commands have been
refactored into a new and appropriately named class of their own. Tests associated with `WanCommands`
have been renamed and split up into tests with names that relate to the newly separated commands.
    
    - [x] There is a JIRA ticket associated with this PR that is referenced in the commit
message
    
    - [x] This PR has been rebased against the latest commit within the target branch
    
    - [x] The initial contribution is a single, squashed commit
    
    - [x] `gradlew build` runs cleanly
    
    - [x] Unit tests have been updated to verify changes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3271

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #647
    
----
commit 6dd031d13473d500181342ba35f203caf1b8edbc
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-19T20:16:03Z

    GEODE-3271: Separating WanCommands into multiple command classes

commit f9a7242f3a4250ad157cfba5a20ff5e9b8b4a688
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-19T20:16:03Z

    GEODE-3271: Separating WanCommands into multiple command classes

commit 0728ccebb4538b7934bf73d7c9ab4aca832ede6d
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-19T22:22:02Z

    Merge branch 'GEODE-3271' of github.com:YehEmily/geode into GEODE-3271

commit 4c9873e46150264c2fb92b64926c603130460c47
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-07-19T22:41:22Z

    Adding tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message