geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Blum <jb...@pivotal.io>
Subject Re: PING message is "Mischief Managed"
Date Thu, 13 Jul 2017 17:44:18 GMT
Yeah, that is my doing. :)

I thought it would be more fun to return a special message than the typical
"Alive".  "Mischief Managed" comes from Harry Potter.

This endpoint is of course benign/idempotent and was purely meant to test
the Management REST API's availability, or rather that the Manage/Locator
was still online.

Unlike JMX RMI, HTTP is stateless.  When a JMX RMI connection is made, it
is persistent and constantly "connected", where as each HTTP request to the
Management REST API is opens and closes a connection each request.
Therefore, you have no idea whether *Gfsh* is still connected to the
Manager between requests unlike the JMX RMI connection.

So, I ran a background Thread that "polls" this endpoint every 500 ms.  It
might even test the message; I don't remember.  Once the response is
anything other than 200 OK, then we no there is a problem and that the
connection was most likely terminated.

Therefore, it keeps the behavior of the HTTP connection similar to the JMX
RMI connection by returning...

No longer connected to 10.99.199.10[1099].

gfsh>


On Thu, Jul 13, 2017 at 10:36 AM, Jacob Barrett <jbarrett@pivotal.io> wrote:

> For the older crowed I would have rather it replied:
>
> Ah, I see you have the machine that goes 'ping!'.
>
> Sent from my iPhone
>
> > On Jul 13, 2017, at 10:23 AM, Jared Stewart <jstewart@pivotal.io> wrote:
> >
> > I'm young enough to recognize it as a Harry Potter reference, but I have
> no
> > idea what it's doing in our product code.
> >
> > - Jared
> >
> >> On Jul 13, 2017 10:14 AM, "Kirk Lund" <klund@apache.org> wrote:
> >>
> >> Anyone know why the response to a REST service PING returns "Mischief
> >> Managed!?
> >>
> >> @RequestMapping(method = {RequestMethod.GET, RequestMethod.HEAD}, value
> =
> >> "/ping")
> >> public ResponseEntity<String> ping() {
> >>  return new ResponseEntity<String>("<html><body><h1>Mischief
> >> Managed!</h1></body></html>",
> >>      HttpStatus.OK);
> >> }
> >>
> >> <klund@Kirks-MacBook-Pro>/Users/klund/dev/geode [949]$ git grep
> 'Mischief
> >> Managed'
> >> geode-core/src/main/java/org/apache/geode/management/
> >> internal/web/controllers/ShellCommandsController.java:
> >>   return new ResponseEntity<String>("<html><body><h1>Mischief
> >> Managed!</h1></body></html>",
> >>
>



-- 
-John
john.blum10101 (skype)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message