geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes
Date Fri, 28 Jul 2017 22:46:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/
-----------------------------------------------------------

(Updated July 28, 2017, 10:46 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Changes
-------

Added javadoc to explain usage. 
Fixed flaky test.


Repository: geode


Description
-------

GEODE-3313: Test utility supports building jar files with multiple classes


Diffs (updated)
-----

  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
PRE-CREATION 
  geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/61166/diff/4/

Changes: https://reviews.apache.org/r/61166/diff/3-4/


Testing
-------

Precheckin running


Thanks,

Jared Stewart


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message