geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes
Date Fri, 28 Jul 2017 17:23:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61166/#review181686
-----------------------------------------------------------


Ship it!




Some javadoc on how to use thes test utilities would be helpful.

- Jinmei Liao


On July 27, 2017, 11:29 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61166/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 11:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3313: Test utility supports building jar files with multiple classes
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractor.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/ClassNameExtractorTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/CompiledSourceCode.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilder.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JarBuilderTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompiler.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/JavaCompilerTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/deployment/compiler/UncompiledSourceCode.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/AbstractFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsAbstractFunction.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ExtendsFunctionAdapter.java
PRE-CREATION 
>   geode-core/src/test/resources/org/apache/geode/management/internal/deployment/compiler/ImplementsFunction.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61166/diff/3/
> 
> 
> Testing
> -------
> 
> Precheckin running
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message