geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kirklund <...@git.apache.org>
Subject [GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...
Date Wed, 26 Jul 2017 22:38:57 GMT
Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/652#discussion_r129712729
  
    --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
    @@ -0,0 +1,396 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.management.internal.cli.shell;
    +
    +import static java.util.concurrent.TimeUnit.MINUTES;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +
    +import junitparams.JUnitParamsRunner;
    +import junitparams.Parameters;
    +import org.junit.Assume;
    +import org.junit.Before;
    +import org.junit.BeforeClass;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +import org.junit.runner.RunWith;
    +
    +import org.apache.geode.internal.AvailablePort;
    +import org.apache.geode.internal.ExitCode;
    +import org.apache.geode.internal.process.PidFile;
    +import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
    +import org.apache.geode.management.internal.cli.util.ThreePhraseGenerator;
    +import org.apache.geode.test.dunit.rules.gfsh.GfshExecution;
    +import org.apache.geode.test.dunit.rules.gfsh.GfshRule;
    +import org.apache.geode.test.dunit.rules.gfsh.GfshScript;
    +import org.apache.geode.test.junit.categories.AcceptanceTest;
    +
    +// Originally created in response to GEODE-2971
    +
    +@Category(AcceptanceTest.class)
    +@RunWith(JUnitParamsRunner.class)
    +public class GfshExitCodeStatusCommandsDUnitTest {
    --- End diff --
    
    I recommend removing "DUnit" from the name especially since it's not categorized as DistributedTest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message