geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kirklund <...@git.apache.org>
Subject [GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...
Date Wed, 26 Jul 2017 22:38:56 GMT
Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/652#discussion_r129714136
  
    --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
---
    @@ -102,35 +107,52 @@ protected ProcessBuilder toProcessBuilder(GfshScript gfshScript,
Path gfshPath,
           commandsToExecute.add("-e " + command);
         }
     
    -    return new ProcessBuilder(commandsToExecute).directory(workingDir);
    +    ProcessBuilder p = new ProcessBuilder(commandsToExecute);
    +    p.directory(workingDir);
    +
    +    // TODO PSRhomberg -- Input requested: Is this OS agnostic
    +    List<String> extendedClasspath = gfshScript.getExtendedClasspath();
    +    if (!extendedClasspath.isEmpty()) {
    +      Map<String, String> m = p.environment();
    +      String classpathKey = "CLASSPATH";
    +      String existingJavaArgs = m.get(classpathKey);
    +      String specified = String.join(":", extendedClasspath);
    --- End diff --
    
    Linux and Mac use ":" as path separator. Use this instead:
    
    org.apache.commons.lang.SystemUtils.PATH_SEPARATOR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message