geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WireBaron <...@git.apache.org>
Subject [GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...
Date Wed, 26 Jul 2017 20:17:35 GMT
Github user WireBaron commented on a diff in the pull request:

    https://github.com/apache/geode/pull/657#discussion_r129684574
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java
---
    @@ -279,26 +280,29 @@ protected void acceptConnection(Socket sock) throws IOException,
ConnectionExcep
           // in our caller.
           // no need to log error here since caller will log warning
     
    -      if (conn != null && !finishedConnecting) {
    +      if (connection != null && !finishedConnecting) {
             // we must be throwing from checkCancelInProgress so close the connection
    -        closeCon(LocalizedStrings.ConnectionTable_CANCEL_AFTER_ACCEPT.toLocalizedString(),
conn);
    -        conn = null;
    +        closeCon(LocalizedStrings.ConnectionTable_CANCEL_AFTER_ACCEPT.toLocalizedString(),
    +            connection);
    +        connection = null;
           }
         }
     
    -    if (conn != null) {
    +    if (connection != null) {
           synchronized (this.receivers) {
    -        this.owner.stats.incReceivers();
    +        this.owner.getStats().incReceivers();
             if (this.closed) {
               closeCon(LocalizedStrings.ConnectionTable_CONNECTION_TABLE_NO_LONGER_IN_USE
    -              .toLocalizedString(), conn);
    +              .toLocalizedString(), connection);
               return;
             }
    -        this.receivers.add(conn);
    +        if (!connection.isSocketClosed()) {
    --- End diff --
    
    The connection removing code is actually spread all over and is done different ways depending
on how and when the connection got closed.  Tracking all of that down is actually where we've
spent the bulk of the four days we were working on this.  The only place we found that was
obviously wrong was this section of code, which wasn't properly dealing with connections that
closed immediately in another thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message