geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...
Date Wed, 26 Jul 2017 18:21:45 GMT
Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/652#discussion_r129656012
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java ---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.internal;
    +
    +import java.util.Arrays;
    +
    +import org.springframework.shell.core.ExitShellRequest;
    +
    +
    +public enum ExitCode {
    +
    +  // The choice of redundant values here is to be consistent with existing behavior
    +  // while allowing for future extensibility. JVM_TERMINATED_EXIT(99) exists for coverage
of
    +  // Spring's ExitShellRequest values in fromSpring.
    +  NORMAL(0),
    +  FATAL(1),
    +  DEPENDENCY_GRAPH_FAILURE(-1),
    +  COULD_NOT_EXECUTE_COMMAND(1),
    +  INVALID_COMMAND(1),
    --- End diff --
    
    I agree in principle, but was hesitant to alter existing behavior for system exit calls.
 I didn't gain any traction in my message to the dev list about using any exit codes other
than `0` and `1`, but at the same time felt that some distinction was warranted in the different
places that `System.exit` had been called.
    
    Then again, I just finished ripping out dead code that had been in place "for future development,"
so perhaps I should keep it simple for now and not do the work of future extensibility that
may or may not ever arrive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message