geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaredjstewart <...@git.apache.org>
Subject [GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings
Date Wed, 26 Jul 2017 17:52:07 GMT
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/651#discussion_r129647633
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
    @@ -639,29 +639,34 @@ public Result compactOfflineDiskStore(
           String errorString = CliStrings.format(
               CliStrings.COMPACT_OFFLINE_DISK_STORE__MSG__ERROR_WHILE_COMPACTING_DISKSTORE_0_WITH_1_REASON_2,
               diskStoreName, fieldsMessage);
    -      result = ResultBuilder.createUserErrorResult(errorString);
    +      result = ResultBuilder.createUserErrorResult(CliStrings.format(
    --- End diff --
    
    This looks to me like it's going to build a strange error message that I expect will look
something like this:: 
    
    ```
    An error occurred while doing compaction: "While compacting disk store={0} {1}. Reason:
{2}"
    ``` 
    
    I think {0} and {1} will be filled in but not {2}.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message