geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Review Request 61119: GEODE-3097: GFSH works over HTTP with SSL
Date Tue, 25 Jul 2017 22:11:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61119/
-----------------------------------------------------------

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

GEODE-3097: GFSH works over HTTP with SSL

put the overhttp change in another test class and have it launhced in geode-assembly, since
only in that module the war file is created.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java
2da95a7c3f305aab4e615d4be7b14c19b9b31dbc 
  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 844e0322eecdc93c4d46c546f4df2d278c5f15cd

  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorWithLegacySSLDUnitTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
df371d28eac9d03cfb69ef462daf56f86bb95738 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectToLocatorSSLOverHttpTest.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/61119/diff/1/


Testing
-------

precheckin successful


Thanks,

Jinmei Liao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message