geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdxrunner <...@git.apache.org>
Subject [GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator
Date Tue, 25 Jul 2017 19:01:16 GMT
Github user pdxrunner commented on a diff in the pull request:

    https://github.com/apache/geode/pull/580#discussion_r129395826
  
    --- Diff: geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java
---
    @@ -173,36 +157,58 @@ public void testUnsupportedOrderByForPR() throws Exception {
     
       @Test
       public void testSupportedOrderByForRR() throws Exception {
    -
         String unsupportedQueries[] =
    -        {"select distinct p.status from /portfolio1 p order by p.status, p.ID",
    -
    -        };
    +        {"select distinct p.status from /portfolio1 p order by p.status, p.ID"};
         Object r[][] = new Object[unsupportedQueries.length][2];
    -    QueryService qs;
    -    qs = CacheUtils.getQueryService();
         Position.resetCounter();
    -    // Create Regions
     
    +    // Create Regions
         Region r1 = CacheUtils.createRegion("portfolio1", Portfolio.class);
     
         for (int i = 0; i < 50; i++) {
           r1.put(new Portfolio(i), new Portfolio(i));
         }
     
         for (int i = 0; i < unsupportedQueries.length; i++) {
    -      Query q = null;
    -
    +      Query q;
           CacheUtils.getLogger().info("Executing query: " + unsupportedQueries[i]);
           q = CacheUtils.getQueryService().newQuery(unsupportedQueries[i]);
           try {
             r[i][0] = q.execute();
    -
           } catch (QueryInvalidException qe) {
             qe.printStackTrace();
             fail(qe.toString());
           }
         }
       }
     
    +  /**
    +   * Tests three cases that were not originally covered by the original tests in this
class. (To
    --- End diff --
    
    This comment probably doesn't need to be a javadoc, and the note about coverage isn't
needed. I'd make this comment say something like, "The following tests cover edge cases in
OrderByComparator".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message