geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhuynh1 <...@git.apache.org>
Subject [GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...
Date Thu, 20 Jul 2017 17:53:32 GMT
Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/609#discussion_r128584345
  
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
---
    @@ -85,8 +72,8 @@ public void execute(FunctionContext context) {
           }
     
         } else {
    -      throw new IllegalArgumentException(
    -          "The AEQ does not exist for the index " + indexName + " region " + region.getFullPath());
    +      resultSender.sendException(new IllegalStateException(
    --- End diff --
    
    I think we should just throw the IllegalStateException, that way it will propagate to
the user and let them know that an AEQ does not exist for the index.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message