geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kohlmu-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow
Date Thu, 20 Jul 2017 16:26:10 GMT
Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/646#discussion_r128388403
  
    --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
    @@ -35,10 +37,9 @@
        * @param errorMessage - description of the error
        * @return An error response containing the above parameters
        */
    -  public static ClientProtocol.Response createErrorResponse(String errorMessage) {
    -    ClientProtocol.ErrorResponse error =
    -        ClientProtocol.ErrorResponse.newBuilder().setMessage(errorMessage).build();
    -    return ClientProtocol.Response.newBuilder().setErrorResponse(error).build();
    +  public static Failure createFailureResult(String errorMessage) {
    --- End diff --
    
    I disagree with this method description or its implementation. Either the method name
should state `createFailureResultWithErrorResponseForErrorMessage` OR the signature becomes
`createFailureResult(ErrorResponse errorResponse)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message