geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From galen-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #634: Feature/geode 3175
Date Tue, 18 Jul 2017 20:11:08 GMT
Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/634#discussion_r128082009
  
    --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ChildVM.java
---
    @@ -49,8 +49,8 @@ public static void main(String[] args) throws Throwable {
           int pid = OSProcess.getId();
           logger.info("VM" + vmNum + " is launching" + (pid > 0 ? " with PID " + pid :
""));
           if (!VersionManager.isCurrentVersion(geodeVersion)) {
    -        logger.info("This VM is using Geode version {}. Version.CURRENT is {}", geodeVersion,
    -            Version.CURRENT);
    +        logger.info("This VM is using Geode version {}. Version.CURRENT is {} (ordinal={})",
    --- End diff --
    
    Worth adding the old ordinal here too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message