geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kohlmu-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #630: GEODE-3141: GetRegion Operation implemented
Date Tue, 18 Jul 2017 17:16:08 GMT
Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/630#discussion_r128038401
  
    --- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
    @@ -52,7 +52,12 @@ message CallbackArguments {
     
     message Region {
    --- End diff --
    
    One would want to avoid just dumping fields into the response object without context.
Given all fields are related to the Region, it is better suited to use a Region message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message