geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anilkumar gingade <aging...@pivotal.io>
Subject Re: Review Request 60874: GEODE-3204: txApplyInvalidate should not modify region entry with a removed token
Date Fri, 14 Jul 2017 19:07:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60874/#review180570
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
Lines 2515 (patched)
<https://reviews.apache.org/r/60874/#comment255778>

    Is't this means the invalidate failed within the tx context? the entry got changed while
applying the tx.
    
    E.g:
    begin tx
    invalidate(key1)
    commit tx
    
    It should invalidate the re under tx lock; if its not able to lock, then it should have
thrown tx conflict exception; or if its removed before taking the lock, it should have thrown
entry-not-found exception...
    
    Now it looks like the invalidate returns true, even if the enty is not invalidated.


- anilkumar gingade


On July 14, 2017, 5:13 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60874/
> -----------------------------------------------------------
> 
> (Updated July 14, 2017, 5:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick
Reich.
> 
> 
> Bugs: GEODE-3204
>     https://issues.apache.org/jira/browse/GEODE-3204
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> txApplyInvalidate no longer modify region entry with a removed token.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java 7f12eab

>   geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java
60b93a9 
> 
> 
> Diff: https://reviews.apache.org/r/60874/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message