geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From metatype <...@git.apache.org>
Subject [GitHub] geode-examples pull request #9: GEODE-3199: Make signing with a gpg key opti...
Date Wed, 12 Jul 2017 22:39:05 GMT
Github user metatype commented on a diff in the pull request:

    https://github.com/apache/geode-examples/pull/9#discussion_r127090456
  
    --- Diff: gradle/release.gradle ---
    @@ -41,17 +41,19 @@ gradle.taskGraph.whenReady( { graph ->
     })
     
     gradle.taskGraph.whenReady { taskGraph ->
    -  if (!version.endsWith('SNAPSHOT')) {
    -    if(!project.hasProperty('signing.keyId') || !project.hasProperty('signing.secretKeyRingFile'))
{
    -      println "You must configure your signing.keyId and signing.secretKeyRingFile"
    -      println "in ~/.gradle/gradle.properties in order to sign jars\n"
    -      println "See https://cwiki.apache.org/confluence/display/GEODE/Release+Steps"
    -      throw new GradleException("Signing key/keyring is missing")
    -    }
    +  if (project.hasProperty('askpass')) {
    --- End diff --
    
    Should this be called `signReleaseArtifacts` since it guards signing (which may cause
the password dialog to appear depending on your environment)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message