geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Rowe <br...@pivotal.io>
Subject Re: Review Request 60718: GEODE-2997: New flow getAll/putAll
Date Wed, 12 Jul 2017 18:01:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60718/
-----------------------------------------------------------

(Updated July 12, 2017, 6:01 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra,
and Udo Kohlmeyer.


Bugs: GEODE-2997
    https://issues.apache.org/jira/browse/GEODE-2997


Repository: geode


Description
-------

Changed get response to indicate if LookupFailure was a missing key or key with null value,
added test
Added GetAllRequestOperationHandler and unit test
Added PutAllRequestOperationHandler and unit test
Added an integration test covering the putAll and getAll operations


Diffs (updated)
-----

  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
714639274 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufRequestUtilities.java
b246a501b 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
d6ef2788e 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
924979329 
  geode-protobuf/src/main/proto/region_API.proto 3108cb7c3 
  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java fee9448af 
  geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
612b9c9a4 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandlerJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
b7d52019e 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
PRE-CREATION 


Diff: https://reviews.apache.org/r/60718/diff/2/

Changes: https://reviews.apache.org/r/60718/diff/1-2/


Testing
-------

Added unit tests for new operation handlers
Added integration test covering new operations


Thanks,

Brian Rowe


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message