geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-jbarrett <...@git.apache.org>
Subject [GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
Date Fri, 07 Jul 2017 10:25:40 GMT
Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/107#discussion_r126116586
  
    --- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp ---
    @@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t* str) {
       return ((str == nullptr) ? L"(null)" : str);
     }
     
    +std::string checkNullString(const std::string* str) {
    +    return ((str == nullptr) ? "(null)" : *str);
    +}
    +
     void _printFields(CacheablePtr field, Struct* ssptr, int32_t& fields) {
       if (auto portfolio = std::dynamic_pointer_cast<Portfolio>(field)) {
         printf("   pulled %s :- ID %d, pkid %s\n",
    -           checkNullString(ssptr->getFieldName(fields)), portfolio->getID(),
    +           checkNullString(ssptr->getFieldName(fields)).c_str(), portfolio->getID(),
    --- End diff --
    
    I think I would just rather see the tests not log so much crap and if they do that they
use a logger with stream functionality. 
    ```
    if (log.debug) {
      log.debug << "Doing some logging. somevar=" << someVar << ", someOtherVar="
<< someOtherVar;
    }
    ```
    😒 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message