geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-jbarrett <...@git.apache.org>
Subject [GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class
Date Fri, 07 Jul 2017 10:20:07 GMT
Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/107#discussion_r126115701
  
    --- Diff: src/cppcache/include/geode/Struct.hpp ---
    @@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
        * Returns the name of the field corresponding to the index number in the
        * Struct
        */
    -  virtual const char* getFieldName(const int32_t index) const;
    +  virtual const std::string* getFieldName(const int32_t index) const;
    --- End diff --
    
    I am too not a huge fan of returning `std::string*` but the current behavior is to return
`nullptr` if the field does not exist at that index. 
    
    @dgkimura would you be happier if this method threw [`out_of_range`](http://en.cppreference.com/w/cpp/error/out_of_range)?
I think I might like that better than null. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message