geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 60666: geode-3166: remove the uncalled getCredential method
Date Thu, 06 Jul 2017 16:03:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/
-----------------------------------------------------------

(Updated July 6, 2017, 4:03 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

geode-3166: remove the uncalled getCredential method

I simply removed the call. Since the new method is never called, if we have any users that's
implementing this method, it's never used anyway. We will not be breaking backward compatibility,
I believe.


Diffs (updated)
-----

  geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 6b0675a5629a3e057fd3d54841db740189007966



Diff: https://reviews.apache.org/r/60666/diff/2/

Changes: https://reviews.apache.org/r/60666/diff/1-2/


Testing
-------

precheckin running


Thanks,

Jinmei Liao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message