Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============7410939267687395221=="
MIME-Version: 1.0
Subject: Re: Review Request 60523: GEODE-3141 New flow: GetRegion
From: Udo Kohlmeyer <ukohlmeyer@gmail.com>
To: Udo Kohlmeyer <ukohlmeyer@gmail.com>,
 Galen O'Sullivan <gosullivan@pivotal.io>,
 Hitesh Khamesra <hkhamesra@pivotal.io>, Brian Rowe <browe@pivotal.io>,
 Alexander Murmann <amurmann@pivotal.io>
Cc: geode <dev@geode.apache.org>, Bruce Schuchardt <bschuchardt@pivotal.io>
Date: Thu, 29 Jun 2017 01:27:38 -0000
Message-ID: <20170629012738.27544.87489@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Udo Kohlmeyer <noreply@reviews.apache.org>
References: <20170628230633.27613.19022@reviews-vm2.apache.org>
In-Reply-To: <20170628230633.27613.19022@reviews-vm2.apache.org>
Reply-To: Udo Kohlmeyer <ukohlmeyer@gmail.com>
archived-at: Thu, 29 Jun 2017 01:27:46 -0000

--===============7410939267687395221==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60523/#review179218
-----------------------------------------------------------


geode-protobuf/src/main/proto/region_API.proto
Lines 117 (patched)
<https://reviews.apache.org/r/60523/#comment253845>

    What does this service do? Just check if a region exists? If so, should we not rename it to `RegionExistsRequest` and `RegionExistsResponse`.
    If this is supposed to do more than just true/false, should we maybe have some extra info that we return? Maybe a `Region` object that contains some region information


- Udo Kohlmeyer


On June 28, 2017, 11:06 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60523/
> -----------------------------------------------------------
> 
> (Updated June 28, 2017, 11:06 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3141
>     https://issues.apache.org/jira/browse/GEODE-3141
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added a GetRegion(regionName) API.  More details about the server region can be added if needed.  This implementation just has a success flag and flag saying whether the region is destroyed.
> 
> 
> Diffs
> -----
> 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java 4318fb444dd0eb5f5d07175a466e26f03933cc4d 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java 4e76de4a15d1ff0cfeddcc2c7115c7c18c2e14ba 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandler.java PRE-CREATION 
>   geode-protobuf/src/main/proto/clientProtocol.proto 0c192950a4e750f7c55e186c18a79a6c52716bf0 
>   geode-protobuf/src/main/proto/region_API.proto d3af17acb1ee45c134837c321b2009c8532817cc 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java dc897241fc229da53a5ff7a0e2df1678b8bceb6d 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java 77b984f7e28a7bfa21b8e1c8c6a83467e9a37242 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionRequestOperationHandlerJUnitTest.java e8f1e651a71240474a793d005164df1ba5d4cda7 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRegionsRequestOperationHandlerJUnitTest.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60523/diff/1/
> 
> 
> Testing
> -------
> 
> new unit tests
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


--===============7410939267687395221==--