Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============5715354205113033247=="
MIME-Version: 1.0
Subject: Re: Review Request 60451: GEODE-2996: adding Put handler
From: Hitesh Khamesra <hkhamesra@pivotal.io>
To: Udo Kohlmeyer <ukohlmeyer@gmail.com>,
 Galen O'Sullivan <gosullivan@pivotal.io>,
 Bruce Schuchardt <bschuchardt@pivotal.io>,
 Hitesh Khamesra <hkhamesra@pivotal.io>,
 Alexander Murmann <amurmann@pivotal.io>
Cc: geode <dev@geode.apache.org>, Brian Rowe <browe@pivotal.io>
Date: Tue, 27 Jun 2017 18:41:10 -0000
Message-ID: <20170627184110.20029.94548@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
In-Reply-To: <20170627012007.8569.80102@reviews-vm2.apache.org>
References: <20170627012007.8569.80102@reviews-vm2.apache.org>
Reply-To: Hitesh Khamesra <hkhamesra@pivotal.io>
Sender: Hitesh Khamesra <noreply@reviews.apache.org>
archived-at: Tue, 27 Jun 2017 18:41:17 -0000

--===============5715354205113033247==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60451/#review179015
-----------------------------------------------------------


Ship it!


Ship It!

- Hitesh Khamesra


On June 27, 2017, 1:20 a.m., Brian Rowe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60451/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 1:20 a.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2996
>     https://issues.apache.org/jira/browse/GEODE-2996
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a continuation of the review Alex submitted this morning with the following changes:
> 
> Addresses review feedback for GEODE-2996, mainly refactoring getOpertionHandler to handle failures like the putOperationHandler
> Adding put operations to the RoundTripCacheConnectionJUnitTest, which is the integration test for the protobuf module
> Removing service loading for protobuf operations and instead have the ProtobufStreamProcessor populate its OperationHandlerRegistry
> Remove exception throwing from OperationHandler.process calls and remove TypeEncodingException
> Fixing ProtobufOpsProcessor to handle responses for types other than get
> 
> 
> Diffs
> -----
> 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java 7683e3bf3 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java 8e3a33149 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java d426149e4 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java d7b5d4bd2 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java d76366298 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java d9c14752f 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java f3145a774 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java c577e768a 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java 5c923a520 
>   geode-protobuf/src/main/proto/region_API.proto 52291c451 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java f0b0b417b 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java b9faca3c9 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java fc980aec9 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java daa5870ed 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60451/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests, whole module test, precheckin in progress.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>


--===============5715354205113033247==--