Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============2863523468700096089=="
MIME-Version: 1.0
Subject: Re: Review Request 60010: GEODE-3062: replace SecurityService after
 loading cluster config
From: Jared Stewart <jstewart@pivotal.io>
To: Jinmei Liao <jiliao@pivotal.io>, Patrick Rhomberg <prhomberg@pivotal.io>,
 Emily Yeh <eyeh@pivotal.io>, Jared Stewart <jstewart@pivotal.io>,
 Ken Howe <khowe@pivotal.io>
Cc: Kirk Lund <kirk.lund@gmail.com>, geode <dev@geode.apache.org>
Date: Wed, 14 Jun 2017 17:46:15 -0000
Message-ID: <20170614174615.7776.44617@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Jared Stewart <noreply@reviews.apache.org>
References: <20170613162903.598.33351@reviews-vm2.apache.org>
In-Reply-To: <20170613162903.598.33351@reviews-vm2.apache.org>
Reply-To: Jared Stewart <jstewart@pivotal.io>
archived-at: Wed, 14 Jun 2017 17:46:19 -0000

--===============2863523468700096089==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60010/#review177927
-----------------------------------------------------------


Ship it!


Ship It!

- Jared Stewart


On June 13, 2017, 4:29 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60010/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 4:29 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3062
>     https://issues.apache.org/jira/browse/GEODE-3062
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug GEODE-3062.
> 
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can be called during Cache construction.
> 
> Move cluster config request to Cache construction and handle jars and properties there. Create new SecurityService in constructor and overwrite the SecurityService in InternalDistributedSystem.
> 
> NOTE: We will later have to fix GEODE-3061 by moving cluster config request from Cache to InternalDistributedSystem construction so that IDS can be created with gemfire.properties from cluster config. At that time we would rip out both cluster config request and creation of security service from Cache construction and pass both into Cache construction.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 22edb6f06c7791929cc9a033ca1a1bfed5751a47 
>   geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 4f4881fe39116faa505bc2fbec74efd669efe0ef 
>   geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 40df0c7dcac8827a381c268c1f90e6acfb97a7f1 
>   geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java c551ca9104a85dcf54c0bebbc4178fce4114a416 
> 
> 
> Diff: https://reviews.apache.org/r/60010/diff/2/
> 
> 
> Testing
> -------
> 
> Precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


--===============2863523468700096089==--