Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A536200C8F for ; Fri, 9 Jun 2017 16:57:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 48D7B160BC8; Fri, 9 Jun 2017 14:57:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91ECB160B9C for ; Fri, 9 Jun 2017 16:57:27 +0200 (CEST) Received: (qmail 51247 invoked by uid 500); 9 Jun 2017 14:57:26 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 51236 invoked by uid 99); 9 Jun 2017 14:57:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Jun 2017 14:57:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 16A2FC090E; Fri, 9 Jun 2017 14:57:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EnfhZuvLfM4z; Fri, 9 Jun 2017 14:57:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id ED6145F5A2; Fri, 9 Jun 2017 14:57:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4EB4EE00A3; Fri, 9 Jun 2017 14:57:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id DF022C40304; Fri, 9 Jun 2017 14:57:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7553146027447569061==" MIME-Version: 1.0 Subject: Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser From: Jinmei Liao To: Kirk Lund , Patrick Rhomberg , Emily Yeh , Jared Stewart , Ken Howe Cc: Jinmei Liao , geode Date: Fri, 09 Jun 2017 14:57:21 -0000 Message-ID: <20170609145721.23549.31959@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jinmei Liao X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59946/ X-Sender: Jinmei Liao X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueConverter.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueAdapter.java Reply-To: Jinmei Liao X-ReviewRequest-Repository: geode archived-at: Fri, 09 Jun 2017 14:57:28 -0000 --===============7553146027447569061== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59946/ ----------------------------------------------------------- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser Diffs ----- geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java df16e9b9e9f71f21ef7c8ac84267a9858ee4298c geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueAdapter.java 5c466a0c70c433d5f595cf3eab903fda8d362f9c geode-core/src/main/java/org/apache/geode/management/internal/cli/MultipleValueConverter.java e3e1fec243fcb2e4048c60510af52c799e9c5110 geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java ab6dc3d10a6235af0ca6fc5164cac5d3c2419cdd Diff: https://reviews.apache.org/r/59946/diff/1/ Testing ------- precheckin successfull hydra test failures related to path name are fixed. Thanks, Jinmei Liao --===============7553146027447569061==--