Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A43B200C8E for ; Thu, 8 Jun 2017 23:16:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 68F50160BD5; Thu, 8 Jun 2017 21:16:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3019F160BC3 for ; Thu, 8 Jun 2017 23:16:28 +0200 (CEST) Received: (qmail 59973 invoked by uid 500); 8 Jun 2017 21:16:27 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 59961 invoked by uid 99); 8 Jun 2017 21:16:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jun 2017 21:16:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8D4491A57AC; Thu, 8 Jun 2017 21:16:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IERD0ZztA5_S; Thu, 8 Jun 2017 21:16:24 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EDE825FCB9; Thu, 8 Jun 2017 21:16:22 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54F8DE06CC; Thu, 8 Jun 2017 21:16:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 930CCC40115; Thu, 8 Jun 2017 21:16:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5917103703656509555==" MIME-Version: 1.0 Subject: Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable From: Kirk Lund To: Kirk Lund , Patrick Rhomberg , Emily Yeh , Jared Stewart , Ken Howe Cc: Jinmei Liao , geode Date: Thu, 08 Jun 2017 21:16:20 -0000 Message-ID: <20170608211620.1778.26709@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kirk Lund X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/59754/ X-Sender: Kirk Lund X-ReviewBoard-ShipIt: 1 References: <20170605200349.26025.93584@reviews-vm2.apache.org> In-Reply-To: <20170605200349.26025.93584@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/TestSuite.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java Reply-To: Kirk Lund X-ReviewRequest-Repository: geode archived-at: Thu, 08 Jun 2017 21:16:29 -0000 --===============5917103703656509555== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177382 ----------------------------------------------------------- Fix it, then Ship it! Fix it and ship it! geode-core/src/test/java/org/apache/TestSuite.java Lines 38 (patched) You probably want to delete this. If you keep it then move it to a deeper package and rename it to something other than TestSuite. - Kirk Lund On June 5, 2017, 8:03 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59754/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 8:03 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > * consolidate the availability indicators > * remove the isGfshVM and isGfshVM() method > * enhance the MultiStepCommand to include info on shellOnly commands to enhance command validation > * remove the SUPPORT_MULTIPLE_GFSH static flag and properly remove the gfsh instance at the end of each test > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/GfeConsoleReaderFactory.java 120d6257b > geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e6dc3973 > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 038e0691e > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java e61934261 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java PRE-CREATION > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java bc9c05b81 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java ad40518f8 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java cb9c4fe50 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 30d840a0f > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 64fafda84 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java 6441f20cc > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java 9d263d110 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2774584ff > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshCommand.java d46024d38 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java b3d96757b > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 4c668b681 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 695718a82 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 9754d7d52 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 9f1290d16 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java d3c263509 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 2009dcc05 > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java efd10d27b > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java fffb9646f > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java 28686ce4d > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java e2164a375 > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java d53261d04 > geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 6708726cd > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java fa0f3b259 > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java f453ec67c > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java c5ff6b6a5 > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 2b39bedd1 > geode-core/src/test/java/org/apache/TestSuite.java PRE-CREATION > geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java PRE-CREATION > geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java 9ea22dac0 > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CliCommandTestBase.java b582e529c > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java 5bbfc5b3d > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java e7ae38e43 > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java bc709db56 > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java da0dfa23c > > > Diff: https://reviews.apache.org/r/59754/diff/1/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > > --===============5917103703656509555==--