Mailing-List: contact dev-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Content-Type: multipart/alternative;
 boundary="===============6111720922223476334=="
MIME-Version: 1.0
Subject: Re: Review Request 59692: GEODE-2925: add target for resource
 operation for finer grained security
From: Patrick Rhomberg <prhomberg@pivotal.io>
To: Kirk Lund <kirk.lund@gmail.com>, Patrick Rhomberg <prhomberg@pivotal.io>,
 Emily Yeh <eyeh@pivotal.io>, Jared Stewart <jstewart@pivotal.io>,
 Ken Howe <khowe@pivotal.io>
Cc: Jinmei Liao <jiliao@pivotal.io>, geode <dev@geode.apache.org>
Date: Fri, 02 Jun 2017 22:45:04 -0000
Message-ID: <20170602224504.16398.44576@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Patrick Rhomberg <noreply@reviews.apache.org>
References: <20170602160821.16397.50281@reviews-vm2.apache.org>
In-Reply-To: <20170602160821.16397.50281@reviews-vm2.apache.org>
Reply-To: Patrick Rhomberg <prhomberg@pivotal.io>
archived-at: Fri, 02 Jun 2017 22:45:09 -0000

--===============6111720922223476334==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59692/#review176859
-----------------------------------------------------------


geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
Line 71 (original)
<https://reviews.apache.org/r/59692/#comment250336>

    We could use an `authorize(Resource r, Operation o, Target t)` that infers `key = "*"`


- Patrick Rhomberg


On June 2, 2017, 4:08 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59692/
> -----------------------------------------------------------
> 
> (Updated June 2, 2017, 4:08 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2925: add target for resource operation for finer grained security
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java 84f97de56 
>   geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java f9fade1cf 
>   geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 14784c391 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 64fafda84 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java c2c6e1425 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java 6514a33e5 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java fe79efbed 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java db3a1872a 
>   geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java 45da46441 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java b728b271e 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java 3f8f4d9d4 
>   geode-core/src/test/java/org/apache/geode/security/SimpleSecurityManagerTest.java 2d6fbcaeb 
>   geode-core/src/test/java/org/apache/geode/security/TestSecurityManager.java 6080b5de8 
>   geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 9cff80d19 
>   geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java 80ff719b0 
> 
> 
> Diff: https://reviews.apache.org/r/59692/diff/6/
> 
> 
> Testing
> -------
> 
> precheckin runing
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


--===============6111720922223476334==--