From dev-return-23874-apmail-geode-dev-archive=geode.apache.org@geode.apache.org Tue Jun 20 00:53:57 2017 Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA50C199B0 for ; Tue, 20 Jun 2017 00:53:57 +0000 (UTC) Received: (qmail 54286 invoked by uid 500); 20 Jun 2017 00:53:57 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 54239 invoked by uid 500); 20 Jun 2017 00:53:57 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 54228 invoked by uid 99); 20 Jun 2017 00:53:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jun 2017 00:53:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E5D1AC86A0; Tue, 20 Jun 2017 00:53:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.99 X-Spam-Level: ** X-Spam-Status: No, score=2.99 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AyqpEf0Ynf7N; Tue, 20 Jun 2017 00:53:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CA19A5F6C3; Tue, 20 Jun 2017 00:53:54 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6EF4BE0051; Tue, 20 Jun 2017 00:53:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id CBD1EC40183; Tue, 20 Jun 2017 00:53:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8361345484769802452==" MIME-Version: 1.0 Subject: Re: Review Request 60157: GEODE-3075: initial work for feature flag and creation of a new subclass of `ServerConnection`. From: Galen O'Sullivan To: Udo Kohlmeyer , Alexander Murmann , Hitesh Khamesra , Brian Rowe , Bruce Schuchardt Cc: geode , Galen O'Sullivan Date: Tue, 20 Jun 2017 00:53:52 -0000 Message-ID: <20170620005352.43050.70843@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Galen O'Sullivan X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60157/ X-Sender: Galen O'Sullivan References: <20170616171428.13752.76610@reviews-vm2.apache.org> In-Reply-To: <20170616171428.13752.76610@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/shiro/SecurityManagerProvider.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java X-ReviewBoard-Diff-For: geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java Reply-To: Galen O'Sullivan X-ReviewRequest-Repository: geode --===============8361345484769802452== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60157/ ----------------------------------------------------------- (Updated June 20, 2017, 12:53 a.m.) Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, and Brian Rowe. Changes ------- Incorporated changes and did some refactoring of `AcceptorImpl`. Repository: geode Description ------- Create `ServerConnectionFactory`, which creates either instances of `LegacyServerConnection` (identical in functionality to the old `ServerConnection`) or `NewProtocolServerConnection` (which is currently basically a stub, but will never get called unless a feature flag is set). This is the initial work for GEODE-3074, and will allow us to continue to work on further tasks for that project. An explicit goal with this PR is to not disturb any existing functionality. Unless a feature flag is set and a connection with a certain magic byte is received, server connections will work as before. If you see something that you think may break, please let me know. Have a nice day! Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 85f914637 geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 5eaa5a4bd geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 9a3241b05 geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java 2a8818cef geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java e0b5ab8b6 geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java 947b83652 geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java 2cb8d0817 geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java 171cfb71a geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java c594bf932 geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java feea8995d geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java 2e0ad956c geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java PRE-CREATION geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java 0e5029bd0 geode-core/src/main/java/org/apache/geode/internal/security/shiro/SecurityManagerProvider.java ad8e66e0c geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java b0e20d9b3 geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryIntegrationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java 794c61097 geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java afa007f31 geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java daaf18d3f geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java bac79ec0e geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java e8548ed86 geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java fc4447bb0 geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java 4b7bbfc5a geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java c47432bbc geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java 86a0ff0ed geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java 94e0be5e0 geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleDistributedTest.java 872740645 geode-docs/developing/transactions/JTA_transactions.html.md.erb ffb6082cc geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java ad5c0806b geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java f62bb7489 Diff: https://reviews.apache.org/r/60157/diff/3/ Changes: https://reviews.apache.org/r/60157/diff/2-3/ Testing ------- precheckin passed (on a version without the integration test, but I'd consider it pretty much equivalent. If you want me to run again, I will.) Thanks, Galen O'Sullivan --===============8361345484769802452==--