geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From YehEmily <...@git.apache.org>
Subject [GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...
Date Fri, 23 Jun 2017 17:31:50 GMT
GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/598

    GEODE-2818: Completing implementation/testing of aliases

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2818)
    
    Changes were previously implemented to allow users to use either `--group` or `--groups`
and `--member` or `--members` and `--jar` or `--jars` when specifying parameters for certain
commands. @sbawaska found that these changes weren't fully implemented for some commands,
though, so this PR aims to fix this. Two tests were also implemented to cover all related
changes:
    
    - `OptionAliasesIntegrationTest.java` uses `GfshRule` to show that these changes work
in the environment (gfsh). Note that this test is not completed yet, as some commands were
impractical to implement (since they required setting up certain permissions, etc.). The test
could also be improved by not only running the commands, but also checking the contents of
the logs written up by the `GfshRule`, although these logs aren't accessible yet (changes
pending via @jaredjstewart). I'll probably file a JIRA ticket to keep track of these improvements
to this test.
    - `OptionAliasesParsingTest.java` shows that all the commands that accept either `--group`
or `--groups` and `--member` or `--members` and `--jar` or `--jars` are parsed correctly.
    
    Some imports were also reordered in the process of implementing changes and writing tests.
    
    **_Precheckin status: pending_**
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #598
    
----
commit 5ccd1ac9ea3208540c52241ccae9e7f1d1fd09fe
Author: YehEmily <emilyyeh1997@gmail.com>
Date:   2017-06-20T19:43:07Z

    GEODE-2818: Making "groups" a valid option when starting locators or servers and adding
a comprehensive test to cover changes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message