geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #569: Resolve Eclipse/IntelliJ import order disagreement
Date Thu, 08 Jun 2017 19:00:40 GMT
GitHub user PurelyApplied opened a pull request:

    https://github.com/apache/geode/pull/569

    Resolve Eclipse/IntelliJ import order disagreement

    The style guides contained in `etc/` are not consistent.
    This commit modifies `etc/intellij-java-google-style.xml` to adhere to the import order
specified in `etc/eclipseOrganizeImports.importorder`.
    This seems a significant enough deviation from the original Google style guide to warrant
a name change in the XML.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PurelyApplied/geode geode-import-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #569
    
----
commit 41c8f7b1651914d61a428f6b8519a8277f2c414d
Author: Patrick Rhomberg <prhomberg@pivotal.io>
Date:   2017-06-08T18:48:47Z

    Resolve Eclipse/IntelliJ import order disagreement in style files.
    
    The style files contained in `etc/` are not consistent between IDEs.
    This commit modifies `etc/intellij-java-google-style.xml` to adhere to the import order
specified in `etc/eclipseOrganizeImports.importorder`.
    This seems a significant enough deviation from the original Google style guide to warrant
a name change in the XML.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message