geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Schuchardt <bschucha...@pivotal.io>
Subject Re: [VOTE] Using Pull Requests over Review Board
Date Mon, 12 Jun 2017 14:57:39 GMT
-1

It places an unnecessary burden on committers and git history is the 
definitive record of changes to the code so github pr history isn't 
really very useful.  Also, Review Board is a much better tool for 
reviewing code than a github PR.


On 6/11/17 9:51 AM, Jacob Barrett wrote:
> After a few days of discussion [1] this thread has quieted down so I would
> like to take it to a vote. The proposal is to modify the workflow of
> committers to match that of non-committers such that committers shall:
>
> * Perform all work in progress on branches in their personal forks on
> GitHub rather than directly on the ASF Geode repositories.
>
> * Submit GitHub pull requests, following all current rules for pull
> requests, for changes that would require peer review before committing to
> the production branches.
>
> * Register their GitHub accounts with the ASF so that committers can be
> identified in the GitHub mirror repositories.
>
>
> Please cast your vote.
>
> [   ] +1  Approve
> [   ] +0  No opinion
> [   ] -1  Disapprove (and reason why)
>
>
> [1] [DISCUSS] Using Pull Requests over Review Board
> <http://geode.markmail.org/message/row5hgz5zw2ooadl?q=list:org%2Eapache%2Egeode%2Edev+discuss+pull>
>
> -Jake
>


Mime
View raw message