geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2989) Improve mechanism for scanning the classpath to find gfsh commands
Date Thu, 01 Jun 2017 16:41:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033276#comment-16033276
] 

ASF subversion and git services commented on GEODE-2989:
--------------------------------------------------------

Commit a0dadadecac83a1fd66b5ac102fc2f91ac216e7e in geode's branch refs/heads/release/1.2.0
from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a0dadad ]

GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

(cherry picked from commit 2f50aef)


> Improve mechanism for scanning the classpath to find gfsh commands
> ------------------------------------------------------------------
>
>                 Key: GEODE-2989
>                 URL: https://issues.apache.org/jira/browse/GEODE-2989
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>             Fix For: 1.3.0
>
>
> The current mechanism for scanning the classpath to find gfsh commands (ClasspathScanLoadHelper)
has some deficiencies, including: 
> 1) Commands can only be scanned for in an exact package ("org.apache.geode.management.internal.cli.commands").
 We can't pick up commands from any subpackages,  prevents us from better organizing the package
structure of our commands (e.g. "org.apache.geode.management.internal.cli.commands.lifecycle").
> 2) All classes in the target package are eagerly loaded, whether or not they contain
commands.  
> Both of these deficiencies can be removed if we replace the implementation of ClasspathScanLoadHelper
with calls to FastClasspathScanner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message