geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2989) Improve mechanism for scanning the classpath to find gfsh commands
Date Thu, 01 Jun 2017 16:07:04 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033213#comment-16033213
] 

ASF subversion and git services commented on GEODE-2989:
--------------------------------------------------------

Commit 2f50aef97311df301cc6492a20954babb68f3ee3 in geode's branch refs/heads/develop from
[~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=2f50aef ]

GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands


> Improve mechanism for scanning the classpath to find gfsh commands
> ------------------------------------------------------------------
>
>                 Key: GEODE-2989
>                 URL: https://issues.apache.org/jira/browse/GEODE-2989
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> The current mechanism for scanning the classpath to find gfsh commands (ClasspathScanLoadHelper)
has some deficiencies, including: 
> 1) Commands can only be scanned for in an exact package ("org.apache.geode.management.internal.cli.commands").
 We can't pick up commands from any subpackages,  prevents us from better organizing the package
structure of our commands (e.g. "org.apache.geode.management.internal.cli.commands.lifecycle").
> 2) All classes in the target package are eagerly loaded, whether or not they contain
commands.  
> Both of these deficiencies can be removed if we replace the implementation of ClasspathScanLoadHelper
with calls to FastClasspathScanner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message