geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Galen M O'Sullivan" <gosulli...@pivotal.io>
Subject Re: [DISCUSS] Using Pull Requests over Review Board
Date Fri, 09 Jun 2017 01:21:59 GMT
One feature I like about PRs on GitHub that I haven't figured out how to do
on Review Board is breaking up a large changeset (which I would like to
have reviewed together) into multiple commits. It can be a useful way to
tell a story about your changes, but keep the review for them in one place.

I'm +0.5 for using GitHub for all code reviews. It's not open source, but
it's free as in beer (well, sort of), and it works well. Having one system
instead of two would be nice and could help make our lives simpler.

On Thu, Jun 8, 2017 at 2:41 PM, Jacob Barrett <jbarrett@pivotal.io> wrote:

> On Thu, Jun 8, 2017 at 2:24 PM Nabarun Nag <nnag@apache.org> wrote:
>
> > Also, IMHO feature branches from which the PRs are created should be in
> our
> > personal fork rather than the main geode git repo.
> >
>
> +1 - I had planned to bring this up in a separate discussion but yes, I
> think all work should happen out of your personal fork as though you are a
> non-committer contributor for consistency. The JIRA issue didn't cross my
> mind because I have a filter to delete all JIRA notifications that aren't
> for new tickets or ticket I am watching.
>
> -Jake
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message