geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Re: Review Request 60375: GEODE-3117: fix Gateway authentication with legacy security
Date Thu, 29 Jun 2017 17:02:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60375/#review179274
-----------------------------------------------------------




geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java
Lines 160 (patched)
<https://reviews.apache.org/r/60375/#comment253925>

    Need to fix this line



geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java
Lines 164 (patched)
<https://reviews.apache.org/r/60375/#comment253926>

    Need to fix this line


- Kirk Lund


On June 26, 2017, 6:02 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60375/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 6:02 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick
Rhomberg.
> 
> 
> Bugs: GEODE-3117
>     https://issues.apache.org/jira/browse/GEODE-3117
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3117: fix Gateway authentication with legacy security
> 
> * add GatewayLegacyAuthenticationRegressionTest to reproduce bug
> * fix authentication of Gateway sender/receiver with SECURITY_CLIENT_AUTHENTICATOR
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionFactoryImpl.java
a419d575010d39d4dab6c5c8f9748928c1764344 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/HandShake.java
32735b9ab17fe9467cea46096bd177902145e4bd 
>   geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/GatewayLegacyAuthenticationRegressionTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60375/diff/1/
> 
> 
> Testing
> -------
> 
> * new test reproduces GEODE-3117: GatewayLegacyAuthenticationRegressionTest
> * precheckin passes
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message