geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Schuchardt <bschucha...@pivotal.io>
Subject Re: Review Request 60451: GEODE-2996: adding Put handler
Date Wed, 28 Jun 2017 19:58:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60451/#review179145
-----------------------------------------------------------



Remove the use of getLogger().  The rest looks okay to me.


geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
Lines 54 (patched)
<https://reviews.apache.org/r/60451/#comment253666>

    New classes should use a Log4j Logger instead of the cache's LogWriter.  Create a static
Logger for this class and in other classes that are using cache.getLogger().



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
Lines 56 (patched)
<https://reviews.apache.org/r/60451/#comment253669>

    ditto & anyplace else getLogger() is being used.



geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
Lines 43 (patched)
<https://reviews.apache.org/r/60451/#comment253670>

    create a Logger for the class


- Bruce Schuchardt


On June 26, 2017, 6:20 p.m., Brian Rowe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60451/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 6:20 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, Hitesh
Khamesra, and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-2996
>     https://issues.apache.org/jira/browse/GEODE-2996
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This is a continuation of the review Alex submitted this morning with the following changes:
> 
> Addresses review feedback for GEODE-2996, mainly refactoring getOpertionHandler to handle
failures like the putOperationHandler
> Adding put operations to the RoundTripCacheConnectionJUnitTest, which is the integration
test for the protobuf module
> Removing service loading for protobuf operations and instead have the ProtobufStreamProcessor
populate its OperationHandlerRegistry
> Remove exception throwing from OperationHandler.process calls and remove TypeEncodingException
> Fixing ProtobufOpsProcessor to handle responses for types other than get
> 
> 
> Diffs
> -----
> 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
7683e3bf3 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
8e3a33149 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
d426149e4 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
d7b5d4bd2 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
d76366298 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
d9c14752f 
>   geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
PRE-CREATION 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
f3145a774 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
c577e768a 
>   geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
5c923a520 
>   geode-protobuf/src/main/proto/region_API.proto 52291c451 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java f0b0b417b 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
b9faca3c9 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
fc980aec9 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
daa5870ed 
>   geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60451/diff/1/
> 
> 
> Testing
> -------
> 
> Unit tests, whole module test, precheckin in progress.
> 
> 
> Thanks,
> 
> Brian Rowe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message