geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaredjstewart <...@git.apache.org>
Subject [GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security
Date Fri, 23 Jun 2017 18:40:49 GMT
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/596#discussion_r123818520
  
    --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
---
    @@ -57,7 +56,48 @@ public void setUp() throws Exception {
       }
     
       @Test
    -  @ConnectionConfiguration(user = "data-admin", password = "1234567")
    +  @ConnectionConfiguration(user = "clusterRead", password = "clusterRead")
    +  public void testClusterReadAccess() throws Exception {
    +    assertThatThrownBy(() -> bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
    --- End diff --
    
    A bunch of tests in this change set can be simplified by using method references in place
of lambda expressions (when the lambdas take no parameters and invoke a no-arg method on the
target):
    ```
    assertThatThrownBy(bean::flush).hasMessageContaining(TestCommand.diskManage.toString());
    ```
    in place of 
    ```
    assertThatThrownBy(() -> bean.flush()).hasMessageContaining(TestCommand.diskManage.toString());
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message