geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Galen O'Sullivan <gosulli...@pivotal.io>
Subject Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.
Date Fri, 23 Jun 2017 17:52:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60394/
-----------------------------------------------------------

(Updated June 23, 2017, 5:52 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer,
and Brian Rowe.


Repository: geode


Description (updated)
-------

This is a merge of https://reviews.apache.org/r/60157 and https://reviews.apache.org/r/60217/
, adding an integration test and a couple small changes. It's probably easiest to read in
comparison to those diffs, or in the git history at https://github.com/apache/geode/pull/597
.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/Acceptor.java 9a3241b05 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImpl.java
2a8818cef 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
e0b5ab8b6 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtocolMessageHandler.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/LegacyServerConnection.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
947b83652 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServiceLoadingFailureException.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactoryTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
794c61097 
  geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
28c6c8a69 
  geode-protobuf/build.gradle PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/SerializationCodecRegistry.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecAlreadyRegisteredForTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/proto/basicTypes.proto PRE-CREATION 
  geode-protobuf/src/main/proto/clientProtocol.proto PRE-CREATION 
  geode-protobuf/src/main/proto/region_API.proto PRE-CREATION 
  geode-protobuf/src/main/proto/server_API.proto PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.internal.cache.tier.sockets.ClientProtocolMessageHandler
PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.protocol.operations.OperationHandler
PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.protocol.serializer.ProtocolSerializer
PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.serialization.TypeCodec
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/IntegrationJUnitTest.java PRE-CREATION

  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/OpsHandler.java PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistryJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/EncodingTypeToSerializationTypeTranslatorJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/serializer/ProtobufProtocolSerializerJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/codec/BinaryFormatJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
PRE-CREATION 
  gradle/dependency-versions.properties 183dafcc6 
  gradle/rat.gradle 1bea5843b 
  settings.gradle c0fdb6e4f 


Diff: https://reviews.apache.org/r/60394/diff/2/


Testing
-------

Precheckin passed on v1 (with the serializable in `excludeClasses.txt` instead of `sanctionedSerializables.txt`).


Thanks,

Galen O'Sullivan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message