geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Rowe <br...@pivotal.io>
Subject Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages
Date Wed, 21 Jun 2017 19:01:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60217/
-----------------------------------------------------------

(Updated June 21, 2017, 7:01 p.m.)


Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra,
and Udo Kohlmeyer.


Repository: geode


Description
-------

This change adds a new module for handling client stresms encoded using the new ProtoBuf protocol.
 At the top level this can be integrated by passing in the input/output streams and cache
reference to the ProtobufStreamProcessor.  This will decode the message and ultimately dispatch
it to an operation specific handler which will call back into the passed cache object.  Note
that this not currently hooked up to geode at all, GEODE-3075 is tracking the work needed
to hook this up at that level.

This change mainly contains the plumbing and encoding/decoding logic, but also contain the
Get operation handler as a proof of concept.  Future work will be needed to handle other types
of operations.


Diffs (updated)
-----

  geode-protobuf/build.gradle PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/exception/InvalidProtocolMessageException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerAlreadyRegisteredException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/exception/OperationHandlerNotRegisteredException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/EncodingTypeTranslator.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSerializationService.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/serializer/ProtobufProtocolSerializer.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/protocol/serializer/ProtocolSerializer.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationService.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/SerializationType.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/TypeCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BinaryCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/BooleanCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/DoubleCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/FloatCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/IntCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/JSONCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/LongCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ShortCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/codec/StringCodec.java PRE-CREATION

  geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/SerializationCodecRegistry.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecAlreadyRegisteredForTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
PRE-CREATION 
  geode-protobuf/src/main/proto/basicTypes.proto PRE-CREATION 
  geode-protobuf/src/main/proto/clientProtocol.proto PRE-CREATION 
  geode-protobuf/src/main/proto/region_API.proto PRE-CREATION 
  geode-protobuf/src/main/proto/server_API.proto PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.protocol.operations.OperationHandler
PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.protocol.serializer.ProtocolSerializer
PRE-CREATION 
  geode-protobuf/src/main/resources/META-INF/services/org.apache.geode.serialization.TypeCodec
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/IntegrationJUnitTest.java PRE-CREATION

  geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/OpsHandler.java PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistryJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/EncodingTypeToSerializationTypeTranslatorJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/protocol/serializer/ProtobufProtocolSerializerJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/ProtobufSerializationServiceJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/codec/BinaryFormatJUnitTest.java
PRE-CREATION 
  geode-protobuf/src/test/java/org/apache/geode/serialization/registry/CodecRegistryJUnitTest.java
PRE-CREATION 
  gradle/dependency-versions.properties 183dafcc6 
  gradle/rat.gradle 1bea5843b 
  settings.gradle c0fdb6e4f 


Diff: https://reviews.apache.org/r/60217/diff/3/

Changes: https://reviews.apache.org/r/60217/diff/2-3/


Testing
-------

Precheckin in progress.  Unit tests added for all new classes, integration test added for
entire module.


Thanks,

Brian Rowe


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message