geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...
Date Mon, 19 Jun 2017 23:27:23 GMT
Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/591#discussion_r122849064
  
    --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java
---
    @@ -941,17 +940,16 @@ private SelectResults prepareEmptyResultSet(ExecutionContext context,
boolean ig
         SelectResults results;
         if (this.distinct || !this.count) {
    --- End diff --
    
    This could stand to be flattened as well, although it will be more difficult that the
above.  I could go either way on this chunk.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message