geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Review Request 60125: GEODE-3062: replace SecurityService after loading cluster config [FIXED]
Date Thu, 15 Jun 2017 22:10:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60125/
-----------------------------------------------------------

Review request for geode, Emily Yeh, Jinmei Liao, Ken Howe, and Patrick Rhomberg.


Bugs: GEODE-3062
    https://issues.apache.org/jira/browse/GEODE-3062


Repository: geode


Description
-------

Fixes:
a) moved deployment of cluster config jars back to initalize after ClassPathLoader
b) added DistributedSystem#disconnect to ServerStarterRule "after" (tests which fail during
Cache create have no GemFireCacheImpl singleton but they do have a InternalDistributedSystem
singleton)

Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug GEODE-3062.

Remove unused Cache param from applyClusterPropertiesConfiguration so it can be called during
Cache construction.

Move cluster config request to Cache construction and handle jars and properties there. Create
new SecurityService in constructor and overwrite the SecurityService in InternalDistributedSystem.

NOTE: We will later have to fix GEODE-3061 by moving cluster config request from Cache to
InternalDistributedSystem construction so that IDS can be created with gemfire.properties
from cluster config. At that time we would rip out both cluster config request and creation
of security service from Cache construction and pass both into Cache construction.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java
22edb6f06c7791929cc9a033ca1a1bfed5751a47 
  geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
4f4881fe39116faa505bc2fbec74efd669efe0ef 
  geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 40df0c7dcac8827a381c268c1f90e6acfb97a7f1

  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
c551ca9104a85dcf54c0bebbc4178fce4114a416 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java fa3e8c0f0bb2fdbf55724e1ba78de7babb5f01b8



Diff: https://reviews.apache.org/r/60125/diff/1/


Testing
-------

precheckin in progress


Thanks,

Kirk Lund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message