geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken Howe <kh...@pivotal.io>
Subject Re: Review Request 60030: GEODE-2925: finer security for disk management
Date Wed, 14 Jun 2017 15:33:06 GMT


> On June 13, 2017, 7:29 p.m., Patrick Rhomberg wrote:
> > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
> > Lines 200-209 (patched)
> > <https://reviews.apache.org/r/60030/diff/1/?file=1749002#file1749002line200>
> >
> >     Kirk has the idea for
> >     
> >     ```
> >     if (StringUtils.isNotBlank(regionFunctionArgs.getDiskStore())) {
> >         getSecurityService().authorize(Resource.CLUSTER, Operation.WRITE, Target.DISK);
> >     }
> >     ```
> >     
> >     That doesn't read quite as clearly as what you have, but can a persistent region
only be instantiated via these region shortcuts?  Or could a customization get around this
check?  (This is a case of me still not knowing the use cases of the product.)

Just checking RegionShortcuts will not get all variations of persisten regions. Regions can
be created without using a predefined shortcut; you can create a custom set of RegionAttributes.
(See the family Cache.createRegionFactory methods.)


- Ken


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60030/#review177787
-----------------------------------------------------------


On June 12, 2017, 9:14 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60030/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 9:14 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2925: finer security for disk management
> 
> changes that are needed to apply the finer grained security for disk management after
the latest security changes.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/management/DiskStoreMXBean.java cca6272610517d75c877945872e1b9e77efae230

>   geode-core/src/main/java/org/apache/geode/management/DistributedSystemMXBean.java f6f701e1faad30839574d8b20fbba31032755e80

>   geode-core/src/main/java/org/apache/geode/management/MemberMXBean.java e2de400601075af880a04b4521898280249d3e99

>   geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemMBean.java
c45da73b4aabfc389b31f9a1092f2abd883813f7 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java
b2f1d561f9ef30dd2c02680b0a1075296719cd61 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
ef2c3dd5db5f193de1ef307813b02f2ef60a4715 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java
0f407e7d3273f4ec6206e24bbc064e207335ee11 
>   geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java
47260bc855025864d0def5855eff33d0cdfd6617 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
e6502c0e4e94b2cea09ff78ea39ebcf02a7197f7 
>   geode-core/src/test/java/org/apache/geode/management/internal/security/DistributedSystemMXBeanSecurityTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60030/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message