geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PurelyApplied <...@git.apache.org>
Subject [GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil
Date Tue, 13 Jun 2017 21:22:43 GMT
Github user PurelyApplied commented on a diff in the pull request:

    https://github.com/apache/geode/pull/578#discussion_r121799720
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java ---
    @@ -1909,10 +1900,7 @@ private static boolean needsSysDir(String cmd) {
         if (cmd.equalsIgnoreCase("version")) {
           return false;
         }
    -    if (cmd.equalsIgnoreCase("help")) {
    -      return false;
    -    }
    -    return true;
    +    return !cmd.equalsIgnoreCase("help");
    --- End diff --
    
    If you want to collapse this block, I think this might read a little better.
    
    ```
    if (cmd.equalsIgnoreCase("stats")
        || cmd.equalsIgnoreCase("merge-logs")
        || cmd.equalsIgnoreCase("version")
        || cmd.equalsIgnoreCase("help")) {
        return false;
    }
    return true;
    ```
    
    I guess you could collapse that to a one-liner, but I don't think that would read as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message