geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Rhomberg <prhomb...@pivotal.io>
Subject Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH
Date Tue, 13 Jun 2017 20:38:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60025/#review177795
-----------------------------------------------------------




geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
Lines 54 (patched)
<https://reviews.apache.org/r/60025/#comment251515>

    Just as a point of order...
    
    You convert the`IOException` to a `RuntimeException` so that (a) tests using this rule
won't have to explicitly catch the `IOException`, and (b) since it's just tests, it's okay
to explode all the way up with the `RuntimeException`?



geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
Lines 83-93 (patched)
<https://reviews.apache.org/r/60025/#comment251516>

    Is there a use case, maybe as we expand to acceptance testing and try to engineer some
race conditions, where we might want to run a script with some expected exit value but not
necessarily wait for it to finish?
    
    My thought is that if you want to quickly spawn two `GfshScript`s with different expected
values, you might give them expected exit values but not wait times, causing an `IllegalStateException`
in line 91.
    
    Maybe additional methods `checkExitCode` and `checkExitCodeAfterWaiting` or something
would help?  I don't know.  I could explain this in person better...


- Patrick Rhomberg


On June 12, 2017, 9:50 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60025/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 9:50 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
PRE-CREATION 
>   geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java PRE-CREATION

>   geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60025/diff/2/
> 
> 
> Testing
> -------
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message