geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dschneider-pivotal <...@git.apache.org>
Subject [GitHub] geode pull request #577: Feature/geode 3049
Date Tue, 13 Jun 2017 19:36:40 GMT
Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/577#discussion_r121751707
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java
---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information
regarding
    + * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may
obtain a
    + * copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express
    + * or implied. See the License for the specific language governing permissions and limitations
under
    + * the License.
    + */
    +package org.apache.geode.internal.cache;
    +
    +/**
    + * Keeps track of redundancy status for a PartitionedRegion and (if enabled) updates
the statistics
    + * for the region.
    + */
    +class BucketRedundancyTracker {
    +  private boolean redundancySatisfied = false;
    --- End diff --
    
    It is not clear, from this class, what makes access to these non final non volatile instance
variables safe.
    Should you add comments on the methods that modify them that those methods are not thread
safe and the caller is responsible for making sure they are not concurrently called by multiple
threads?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message